AdamThomasandClaude Sonnet 5
be51770b51
Compétences supprimées de bout en bout :
- tables `skill`, `volunteer_skill`, `shift_required_skill` ;
- `Volunteer.skill_codes`, `Shift.required_skill_codes`, colonne `skills`
de l'import, règle de validation `MISSING_REQUIRED_SKILL`, jeu de démo.
Disponibilités repensées : `Availability` passe de (`day_part_id`,
`status` tri-état) à une **fenêtre horaire libre** (`date`, `start_time`,
`end_time` ; `end <= start` ⇒ passe minuit), plusieurs par jour.
- Nouveaux endpoints `GET`/`PUT /editions/{id}/volunteers/{vid}/availability`
(PUT = remplacement complet, COORDINATION) et
`GET /editions/{id}/availability` (toute l'édition, pour la grille).
- `OUTSIDE_AVAILABILITY` (toujours WARNING) : compare le créneau à l'union
des fenêtres du bénévole ce jour-là ; renvoie `date` + `uncovered_minutes`.
`DayPart` ne sert plus qu'à la borne de « journée » du cumul 8 h.
- L'import ne gère plus les disponibilités (fenêtres saisies dans l'app) :
`values.py` supprimé, mapping réduit à nom/email/téléphone/commentaire.
Migration 0007 (recrée `availability`). `AvailabilityStatus` supprimé.
158 tests, `alembic check` et `ruff` au vert. Front à suivre.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017uUsRg7XzopkCPWimwg9ZM
99 lines
2.9 KiB
Python
99 lines
2.9 KiB
Python
import json
|
|
import uuid
|
|
|
|
from sqlmodel import select
|
|
|
|
from app.models import Volunteer
|
|
|
|
_CSV = (
|
|
"Prénom;Nom;Email;Téléphone\n"
|
|
"Alex;Martin;alex@ex.fr;0600000000\n"
|
|
"Sam;Nguyen;sam@ex.fr;\n"
|
|
).encode()
|
|
|
|
|
|
def _mapping(dry_run: bool) -> str:
|
|
return json.dumps(
|
|
{
|
|
"dry_run": dry_run,
|
|
"columns": {
|
|
"first_name": "Prénom",
|
|
"last_name": "Nom",
|
|
"email": "Email",
|
|
"phone": "Téléphone",
|
|
},
|
|
}
|
|
)
|
|
|
|
|
|
def test_analyze_returns_headers_preview_and_suggestion(client, edition):
|
|
resp = client.post(
|
|
f"/editions/{edition.id}/import/analyze",
|
|
files={"file": ("benevoles.csv", _CSV, "text/csv")},
|
|
)
|
|
assert resp.status_code == 200
|
|
body = resp.json()
|
|
assert body["format"] == "csv"
|
|
assert body["headers"] == ["Prénom", "Nom", "Email", "Téléphone"]
|
|
assert body["row_count"] == 2
|
|
assert body["preview"][0]["values"]["Nom"] == "Martin"
|
|
assert body["suggested_mapping"]["first_name"] == "Prénom"
|
|
assert body["suggested_mapping"]["phone"] == "Téléphone"
|
|
|
|
|
|
def test_execute_dry_run_then_real(client, session, edition):
|
|
dry = client.post(
|
|
f"/editions/{edition.id}/import/execute",
|
|
files={"file": ("benevoles.csv", _CSV, "text/csv")},
|
|
data={"mapping": _mapping(dry_run=True)},
|
|
)
|
|
assert dry.status_code == 200
|
|
assert dry.json()["created"] == 2
|
|
assert session.exec(select(Volunteer)).all() == []
|
|
|
|
real = client.post(
|
|
f"/editions/{edition.id}/import/execute",
|
|
files={"file": ("benevoles.csv", _CSV, "text/csv")},
|
|
data={"mapping": _mapping(dry_run=False)},
|
|
)
|
|
assert real.status_code == 200
|
|
assert real.json()["created"] == 2
|
|
assert len(session.exec(select(Volunteer)).all()) == 2
|
|
|
|
|
|
def test_execute_rejects_invalid_mapping(client, edition):
|
|
bad_mapping = json.dumps(
|
|
{
|
|
"dry_run": True,
|
|
"columns": {"first_name": "Prénom", "last_name": "Absente"},
|
|
}
|
|
)
|
|
resp = client.post(
|
|
f"/editions/{edition.id}/import/execute",
|
|
files={"file": ("benevoles.csv", _CSV, "text/csv")},
|
|
data={"mapping": bad_mapping},
|
|
)
|
|
assert resp.status_code == 422
|
|
detail = resp.json()["detail"]
|
|
assert detail["code"] == "import.mapping.invalid"
|
|
assert any(
|
|
e["code"] == "import.mapping.column_not_found" for e in detail["errors"]
|
|
)
|
|
|
|
|
|
def test_analyze_unknown_edition_is_404(client):
|
|
resp = client.post(
|
|
f"/editions/{uuid.uuid4()}/import/analyze",
|
|
files={"file": ("benevoles.csv", _CSV, "text/csv")},
|
|
)
|
|
assert resp.status_code == 404
|
|
|
|
|
|
def test_analyze_rejects_empty_file(client, edition):
|
|
resp = client.post(
|
|
f"/editions/{edition.id}/import/analyze",
|
|
files={"file": ("benevoles.csv", b"", "text/csv")},
|
|
)
|
|
assert resp.status_code == 400
|
|
assert resp.json()["detail"]["code"] == "import.error.empty_file"
|