AdamThomasandClaude Sonnet 5
be51770b51
Compétences supprimées de bout en bout :
- tables `skill`, `volunteer_skill`, `shift_required_skill` ;
- `Volunteer.skill_codes`, `Shift.required_skill_codes`, colonne `skills`
de l'import, règle de validation `MISSING_REQUIRED_SKILL`, jeu de démo.
Disponibilités repensées : `Availability` passe de (`day_part_id`,
`status` tri-état) à une **fenêtre horaire libre** (`date`, `start_time`,
`end_time` ; `end <= start` ⇒ passe minuit), plusieurs par jour.
- Nouveaux endpoints `GET`/`PUT /editions/{id}/volunteers/{vid}/availability`
(PUT = remplacement complet, COORDINATION) et
`GET /editions/{id}/availability` (toute l'édition, pour la grille).
- `OUTSIDE_AVAILABILITY` (toujours WARNING) : compare le créneau à l'union
des fenêtres du bénévole ce jour-là ; renvoie `date` + `uncovered_minutes`.
`DayPart` ne sert plus qu'à la borne de « journée » du cumul 8 h.
- L'import ne gère plus les disponibilités (fenêtres saisies dans l'app) :
`values.py` supprimé, mapping réduit à nom/email/téléphone/commentaire.
Migration 0007 (recrée `availability`). `AvailabilityStatus` supprimé.
158 tests, `alembic check` et `ruff` au vert. Front à suivre.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017uUsRg7XzopkCPWimwg9ZM
72 lines
2.3 KiB
Python
72 lines
2.3 KiB
Python
import datetime as dt
|
|
|
|
from app.models import Assignment
|
|
from app.validation import AvailabilityWindow
|
|
from app.validation.loader import build_validation_input
|
|
from tests.factories import (
|
|
dt_at,
|
|
make_availability,
|
|
make_position,
|
|
make_shift,
|
|
make_volunteer,
|
|
)
|
|
|
|
|
|
def test_build_input_gathers_everything_from_db(client, edition, session, day_parts):
|
|
position = make_position(session, edition)
|
|
candidate = make_shift(
|
|
session, edition, position, start=dt_at(10, 14), end=dt_at(10, 18)
|
|
)
|
|
other_shift = make_shift(
|
|
session, edition, position, start=dt_at(11, 9), end=dt_at(11, 12)
|
|
)
|
|
volunteer = make_volunteer(session, edition, email="v@ex.fr")
|
|
make_availability(
|
|
session, edition, volunteer,
|
|
date=dt.date(2026, 7, 10),
|
|
start_time=dt.time(13, 0), end_time=dt.time(19, 0),
|
|
)
|
|
session.add(
|
|
Assignment(
|
|
edition_id=edition.id, volunteer_id=volunteer.id,
|
|
shift_id=other_shift.id,
|
|
)
|
|
)
|
|
session.commit()
|
|
|
|
data = build_validation_input(
|
|
session=session, edition=edition, volunteer=volunteer, shift=candidate
|
|
)
|
|
|
|
assert data.candidate_shift.id == str(candidate.id)
|
|
# Toute affectation existante compte, sauf le créneau candidat lui-même.
|
|
assert [s.id for s in data.existing_shifts] == [str(other_shift.id)]
|
|
assert len(data.day_parts) == 3
|
|
assert data.availabilities == (
|
|
AvailabilityWindow(dt.date(2026, 7, 10), dt.time(13, 0), dt.time(19, 0)),
|
|
)
|
|
|
|
|
|
def test_exclude_assignment_id_is_honoured(client, edition, session, day_parts):
|
|
position = make_position(session, edition)
|
|
candidate = make_shift(
|
|
session, edition, position, start=dt_at(10, 14), end=dt_at(10, 18)
|
|
)
|
|
other_shift = make_shift(
|
|
session, edition, position, start=dt_at(11, 9), end=dt_at(11, 12)
|
|
)
|
|
volunteer = make_volunteer(session, edition, email="v@ex.fr")
|
|
own = Assignment(
|
|
edition_id=edition.id, volunteer_id=volunteer.id,
|
|
shift_id=other_shift.id,
|
|
)
|
|
session.add(own)
|
|
session.commit()
|
|
session.refresh(own)
|
|
|
|
data = build_validation_input(
|
|
session=session, edition=edition, volunteer=volunteer,
|
|
shift=candidate, exclude_assignment_id=own.id,
|
|
)
|
|
assert data.existing_shifts == ()
|