AdamThomasandClaude Sonnet 5
be51770b51
Compétences supprimées de bout en bout :
- tables `skill`, `volunteer_skill`, `shift_required_skill` ;
- `Volunteer.skill_codes`, `Shift.required_skill_codes`, colonne `skills`
de l'import, règle de validation `MISSING_REQUIRED_SKILL`, jeu de démo.
Disponibilités repensées : `Availability` passe de (`day_part_id`,
`status` tri-état) à une **fenêtre horaire libre** (`date`, `start_time`,
`end_time` ; `end <= start` ⇒ passe minuit), plusieurs par jour.
- Nouveaux endpoints `GET`/`PUT /editions/{id}/volunteers/{vid}/availability`
(PUT = remplacement complet, COORDINATION) et
`GET /editions/{id}/availability` (toute l'édition, pour la grille).
- `OUTSIDE_AVAILABILITY` (toujours WARNING) : compare le créneau à l'union
des fenêtres du bénévole ce jour-là ; renvoie `date` + `uncovered_minutes`.
`DayPart` ne sert plus qu'à la borne de « journée » du cumul 8 h.
- L'import ne gère plus les disponibilités (fenêtres saisies dans l'app) :
`values.py` supprimé, mapping réduit à nom/email/téléphone/commentaire.
Migration 0007 (recrée `availability`). `AvailabilityStatus` supprimé.
158 tests, `alembic check` et `ruff` au vert. Front à suivre.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017uUsRg7XzopkCPWimwg9ZM
68 lines
2.2 KiB
Python
68 lines
2.2 KiB
Python
from app.models import Role, Shift
|
|
from tests.factories import dt_at, make_position, make_shift
|
|
|
|
|
|
def _url(edition, suffix=""):
|
|
return f"/editions/{edition.id}/day-parts{suffix}"
|
|
|
|
|
|
def test_list_returns_the_three_fixture_types(client, edition):
|
|
body = client.get(_url(edition)).json()
|
|
assert [d["code"] for d in body] == ["MORNING", "AFTERNOON", "EVENING"]
|
|
|
|
|
|
def test_create_slugs_the_code_from_the_label(client, edition):
|
|
resp = client.post(
|
|
_url(edition),
|
|
json={"label": "Nuit profonde", "start_time": "02:00", "end_time": "06:00", "order": 3},
|
|
)
|
|
assert resp.status_code == 201
|
|
assert resp.json()["code"] == "NUIT_PROFONDE"
|
|
|
|
|
|
def test_create_duplicate_code_conflicts(client, edition):
|
|
body = {
|
|
"code": "MORNING",
|
|
"label": "Matin bis",
|
|
"start_time": "06:00",
|
|
"end_time": "13:00",
|
|
}
|
|
resp = client.post(_url(edition), json=body)
|
|
assert resp.status_code == 409
|
|
assert resp.json()["detail"]["code"] == "day_part.duplicate_code"
|
|
|
|
|
|
def test_update_day_part(client, edition):
|
|
dp_id = client.get(_url(edition)).json()[0]["id"]
|
|
resp = client.patch(
|
|
_url(edition, f"/{dp_id}"), json={"label": "Tôt le matin", "end_time": "12:00"}
|
|
)
|
|
assert resp.status_code == 200
|
|
assert resp.json()["label"] == "Tôt le matin"
|
|
assert resp.json()["end_time"] == "12:00:00"
|
|
|
|
|
|
def test_delete_sets_shift_day_part_to_null(client, edition, session, day_parts):
|
|
morning = day_parts["MORNING"]
|
|
position = make_position(session, edition)
|
|
shift = make_shift(
|
|
session, edition, position, start=dt_at(10, 6), end=dt_at(10, 13)
|
|
)
|
|
shift.day_part_id = morning.id
|
|
session.commit()
|
|
|
|
assert client.delete(_url(edition, f"/{morning.id}")).status_code == 204
|
|
session.expire_all()
|
|
assert session.get(Shift, shift.id).day_part_id is None
|
|
|
|
|
|
def test_write_is_coordinator_only(edition, make_account, as_account):
|
|
lead = make_account(Role.LEAD, email="lead@e.fr")
|
|
client = as_account(lead)
|
|
assert client.get(_url(edition)).status_code == 200
|
|
resp = client.post(
|
|
_url(edition),
|
|
json={"label": "X", "start_time": "08:00", "end_time": "09:00"},
|
|
)
|
|
assert resp.status_code == 403
|