Files
benevoles/backend/app/api/assignments.py
T
AdamThomasandClaude Sonnet 5 74e35f0195 Étape 5 : API CRUD, matrice et validation branchée
- CRUD complet, scopé par édition, sur Position, Shift, Volunteer, Assignment
  (routers app/api/*, schémas Pydantic, dépendance get_edition partagée)
- Volunteer : gestion des compétences par codes (création à la volée),
  suppression = effacement complet en cascade (RGPD)
- Shift : contrôle fin > début, poste de la même édition, compétences requises
- Assignment : toute écriture active passe par le moteur de validation ;
  violation bloquante -> 422 error.validation_failed, avertissements renvoyés
  dans la réponse. Endpoint POST .../assignments/validate en simulation.
  app/validation/loader.py construit la ValidationInput depuis la base.
- GET /editions/{id}/matrix : postes -> créneaux -> {min, ideal, confirmed,
  proposed}, source de l'écran principal
- 30 tests d'API (CRUD, 404/409/422, cascade, blocage, avertissements, matrice,
  loader) ; 104 tests au total ; alembic check toujours vert
- Clés de traduction shift.* / assignment.* / volunteer.* ajoutées

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017uUsRg7XzopkCPWimwg9ZM
2026-09-09 22:54:22 +02:00

208 lines
6.5 KiB
Python

"""CRUD des affectations. Toute écriture passe par le moteur de validation :
une violation bloquante interdit l'enregistrement, les avertissements sont
renvoyés."""
import uuid
from fastapi import APIRouter, Depends, HTTPException, Response, status
from sqlmodel import Session, select
from app.api._common import owned_or_404
from app.api.deps import get_edition
from app.api.schemas import (
AssignmentCreate,
AssignmentRead,
AssignmentUpdate,
AssignmentValidateRequest,
AssignmentValidateResult,
AssignmentWriteResult,
)
from app.db import get_session
from app.models import (
ACTIVE_ASSIGNMENT_STATUSES,
Assignment,
Edition,
Shift,
Volunteer,
)
from app.validation import has_blocking, validate
from app.validation.loader import build_validation_input
router = APIRouter(
prefix="/editions/{edition_id}/assignments", tags=["assignments"]
)
def _pair_or_422(
session: Session, edition_id: uuid.UUID, volunteer_id: uuid.UUID, shift_id: uuid.UUID
) -> tuple[Volunteer, Shift]:
volunteer = session.get(Volunteer, volunteer_id)
shift = session.get(Shift, shift_id)
if (
volunteer is None
or shift is None
or volunteer.edition_id != edition_id
or shift.edition_id != edition_id
):
raise HTTPException(
status_code=422, detail={"code": "assignment.wrong_edition"}
)
return volunteer, shift
@router.post(
"/validate", response_model=AssignmentValidateResult, tags=["assignments"]
)
def validate_assignment(
payload: AssignmentValidateRequest,
edition: Edition = Depends(get_edition),
session: Session = Depends(get_session),
) -> AssignmentValidateResult:
volunteer, shift = _pair_or_422(
session, edition.id, payload.volunteer_id, payload.shift_id
)
violations = validate(
build_validation_input(
session=session, edition=edition, volunteer=volunteer, shift=shift
)
)
return AssignmentValidateResult(
blocking=has_blocking(violations), violations=violations
)
@router.post(
"", response_model=AssignmentWriteResult, status_code=status.HTTP_201_CREATED
)
def create_assignment(
payload: AssignmentCreate,
edition: Edition = Depends(get_edition),
session: Session = Depends(get_session),
) -> AssignmentWriteResult:
volunteer, shift = _pair_or_422(
session, edition.id, payload.volunteer_id, payload.shift_id
)
existing = session.exec(
select(Assignment)
.where(Assignment.volunteer_id == volunteer.id)
.where(Assignment.shift_id == shift.id)
).first()
if existing is not None:
raise HTTPException(
status_code=409, detail={"code": "assignment.duplicate"}
)
# La validation ne s'applique qu'aux affectations actives : créer
# directement une affectation DECLINEE ou ANNULEE n'a rien à valider.
violations: list = []
if payload.status in ACTIVE_ASSIGNMENT_STATUSES:
violations = validate(
build_validation_input(
session=session,
edition=edition,
volunteer=volunteer,
shift=shift,
)
)
if has_blocking(violations):
raise HTTPException(
status_code=422,
detail={
"code": "error.validation_failed",
"violations": [v.model_dump() for v in violations],
},
)
assignment = Assignment(
edition_id=edition.id,
volunteer_id=volunteer.id,
shift_id=shift.id,
status=payload.status,
source=payload.source,
locked=payload.locked,
)
session.add(assignment)
session.commit()
session.refresh(assignment)
return AssignmentWriteResult(assignment=assignment, warnings=violations)
@router.get("", response_model=list[AssignmentRead])
def list_assignments(
volunteer_id: uuid.UUID | None = None,
shift_id: uuid.UUID | None = None,
edition: Edition = Depends(get_edition),
session: Session = Depends(get_session),
) -> list[Assignment]:
stmt = select(Assignment).where(Assignment.edition_id == edition.id)
if volunteer_id is not None:
stmt = stmt.where(Assignment.volunteer_id == volunteer_id)
if shift_id is not None:
stmt = stmt.where(Assignment.shift_id == shift_id)
return list(session.exec(stmt))
@router.get("/{assignment_id}", response_model=AssignmentRead)
def get_assignment(
assignment_id: uuid.UUID,
edition: Edition = Depends(get_edition),
session: Session = Depends(get_session),
) -> Assignment:
return owned_or_404(session.get(Assignment, assignment_id), edition.id)
@router.patch("/{assignment_id}", response_model=AssignmentWriteResult)
def update_assignment(
assignment_id: uuid.UUID,
payload: AssignmentUpdate,
edition: Edition = Depends(get_edition),
session: Session = Depends(get_session),
) -> AssignmentWriteResult:
assignment = owned_or_404(
session.get(Assignment, assignment_id), edition.id
)
changes = payload.model_dump(exclude_unset=True)
for field, value in changes.items():
setattr(assignment, field, value)
warnings: list = []
if assignment.status in ACTIVE_ASSIGNMENT_STATUSES:
volunteer = session.get(Volunteer, assignment.volunteer_id)
shift = session.get(Shift, assignment.shift_id)
warnings = validate(
build_validation_input(
session=session,
edition=edition,
volunteer=volunteer,
shift=shift,
exclude_assignment_id=assignment.id,
)
)
if has_blocking(warnings):
session.rollback()
raise HTTPException(
status_code=422,
detail={
"code": "error.validation_failed",
"violations": [v.model_dump() for v in warnings],
},
)
session.commit()
session.refresh(assignment)
return AssignmentWriteResult(assignment=assignment, warnings=warnings)
@router.delete("/{assignment_id}", status_code=status.HTTP_204_NO_CONTENT)
def delete_assignment(
assignment_id: uuid.UUID,
edition: Edition = Depends(get_edition),
session: Session = Depends(get_session),
) -> Response:
assignment = owned_or_404(
session.get(Assignment, assignment_id), edition.id
)
session.delete(assignment)
session.commit()
return Response(status_code=status.HTTP_204_NO_CONTENT)